feat: add support for choropleth map & clean up chart types #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-rocheleau
approved these changes
Sep 28, 2023
| the field metadata (description / mapping information / units / etc.) By using a sum type here, we can optionally | ||
| mandate configuration information for certain types of charts. | ||
| */ | ||
| export type ChartConfig = |
There was a problem hiding this comment.
Would make three distinct types and then sum type them like:
export type ChartConfig = PieChartConfig | BarChartConfig | ChoroplethChartConfig;Makes it more readable imo, and we may want to import a specific type later.
There was a problem hiding this comment.
I agree, did this already in another WIP branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.