Skip to content

Commit

Permalink
Merge pull request #230 from bento-platform/chore/update
Browse files Browse the repository at this point in the history
chore: updates - node 22, base img, package+lock deps
  • Loading branch information
davidlougheed authored Nov 22, 2024
2 parents a7ba63f + 3713020 commit ec482e9
Show file tree
Hide file tree
Showing 5 changed files with 341 additions and 348 deletions.
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM --platform=$BUILDPLATFORM node:20-bookworm-slim AS build
FROM --platform=$BUILDPLATFORM node:22-bookworm-slim AS build

# Build bento_public with NodeJS + Webpack
# - Use BUILDPLATFORM for running webpack, since it should perform a lot better.
Expand All @@ -24,13 +24,13 @@ RUN npm run build
FROM nginx:1.26

# Install node so that we can run the create_config_prod.js & create_service_info.js scripts
RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - && \
RUN curl -fsSL https://deb.nodesource.com/setup_22.x | bash - && \
apt-get update -y && \
apt-get install -y ca-certificates curl gnupg && \
mkdir -p /etc/apt/keyrings && \
curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | \
gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg && \
echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_20.x nodistro main" | \
echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_22.x nodistro main" | \
tee /etc/apt/sources.list.d/nodesource.list && \
apt-get install -y nodejs && \
rm -rf /var/lib/apt/lists/*
Expand Down
4 changes: 2 additions & 2 deletions dev.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM --platform=$BUILDPLATFORM node:20-bookworm-slim AS install
FROM --platform=$BUILDPLATFORM node:22-bookworm-slim AS install

WORKDIR /bento-public

Expand All @@ -7,7 +7,7 @@ COPY package-lock.json .

RUN npm ci

FROM ghcr.io/bento-platform/bento_base_image:node-debian-2024.10.01
FROM ghcr.io/bento-platform/bento_base_image:node-debian-2024.11.01

LABEL org.opencontainers.image.description="Local development image for Bento Public."

Expand Down
Loading

0 comments on commit ec482e9

Please sign in to comment.