Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact!: remove bundles (deprecated part of spec) #124

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

davidlougheed
Copy link
Member

@davidlougheed davidlougheed commented Jul 17, 2024

also changes service type + implements (most of) spec 1.4.0.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.62%. Comparing base (46a3cf5) to head (654976d).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   95.61%   95.62%   +0.01%     
==========================================
  Files          20       20              
  Lines         638      572      -66     
  Branches       82       69      -13     
==========================================
- Hits          610      547      -63     
+ Misses         20       19       -1     
+ Partials        8        6       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of questions

pyproject.toml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidlougheed davidlougheed merged commit 568d202 into master Aug 20, 2024
6 checks passed
@davidlougheed davidlougheed deleted the refact/remove-bundles branch August 20, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants