Merge pull request #107 from bento-platform/fix/handle-method-not-all…

…owed

fix: handle MethodNotAllowed errors

chord_drs/app.py

@@ -4,7 +4,7 @@
 from flask import Flask
 from flask_cors import CORS
 from flask_migrate import Migrate
-from werkzeug.exceptions import BadRequest, Forbidden, NotFound, RequestedRangeNotSatisfiable
+from werkzeug.exceptions import BadRequest, Forbidden, NotFound, MethodNotAllowed, RequestedRangeNotSatisfiable
 
 from .authz import authz_middleware
 from .backend import close_backend
@@ -47,19 +47,11 @@
 )
 application.register_error_handler(
     BadRequest,
-    flask_errors.flask_error_wrap(
-        flask_errors.flask_bad_request_error,
-        drs_compat=True,
-        authz=authz_middleware,
-    ),
+    flask_errors.flask_error_wrap(flask_errors.flask_bad_request_error, drs_compat=True, authz=authz_middleware),
 )
 application.register_error_handler(
     Forbidden,
-    flask_errors.flask_error_wrap(
-        flask_errors.flask_forbidden_error,
-        drs_compat=True,
-        authz=authz_middleware,
-    ),
+    flask_errors.flask_error_wrap(flask_errors.flask_forbidden_error, drs_compat=True, authz=authz_middleware),
 )
 application.register_error_handler(
     NotFound,
@@ -70,6 +62,10 @@
         authz=authz_middleware,
     )(e),
 )
+application.register_error_handler(
+    MethodNotAllowed,
+    flask_errors.flask_error_wrap(flask_errors.flask_method_not_allowed_error, drs_compat=True, authz=authz_middleware),
+)
 application.register_error_handler(
     RequestedRangeNotSatisfiable,
     flask_errors.flask_error_wrap(

pyproject.toml

@@ -14,7 +14,7 @@ include = [
 [tool.poetry.dependencies]
 python = "^3.10"
 boto3 = ">=1.34.81,<1.35"
-bento-lib = {version = "^11.5.2", extras = ["flask"]}
+bento-lib = {version = "^11.6.0", extras = ["flask"]}
 flask = ">=2.2.5,<2.3"
 flask-sqlalchemy = ">=3.1.1,<3.2"
 flask-migrate = ">=4.0.5,<4.1"

tests/test_routes.py

@@ -70,6 +70,11 @@ def test_service_info(client):
     validate(data, bento_lib.schemas.ga4gh.SERVICE_INFO_SCHEMA)
 
 
+def test_method_not_allowed(client):
+    res = client.post("/service-info")
+    assert res.status_code == 405
+
+
 def authz_everything_true(count=1):
     responses.post(f"{AUTHZ_URL}/policy/evaluate", json={"result": [[True] for _ in range(count)]})