Merge pull request #98 from bento-platform/chore/compliant-drs-uris

chore!: switch to generating spec-compliant DRS URIs
bento-platform · Apr 10, 2024 · 3234221 · 3234221
2 parents 0920edd + b37df29
commit 3234221
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 26 deletions.
diff --git a/chord_drs/routes.py b/chord_drs/routes.py
@@ -116,13 +116,12 @@ def range_not_satisfiable_log_mark(description: str, length: int) -> RequestedRa
     return RequestedRangeNotSatisfiable(description=description, length=length)
 
 
-def get_drs_base_path() -> str:
-    parsed_service_url = urlparse(current_app.config["SERVICE_BASE_URL"])
-    return f"{parsed_service_url.netloc}{parsed_service_url.path}"
+def get_drs_host() -> str:
+    return urlparse(current_app.config["SERVICE_BASE_URL"]).netloc
 
 
 def create_drs_uri(object_id: str) -> str:
-    return f"drs://{get_drs_base_path()}/{object_id}"
+    return f"drs://{get_drs_host()}/{object_id}"
 
 
 def build_contents(bundle: DrsBundle, expand: bool) -> list[DRSContentsDict]:

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "chord-drs"
-version = "0.15.3"
+version = "0.16.0"
 description = "An implementation of a data repository system (as per GA4GH's specs) for the Bento platform."
 authors = ["David Lougheed <[email protected]>"]
 license = "LGPL-3.0"