Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore dataset description if katsu down #80

Merged
merged 1 commit into from
Apr 25, 2024
Merged

ignore dataset description if katsu down #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion bento_beacon/utils/katsu_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,11 @@ def katsu_total_individuals_count():
def katsu_datasets(id=None):
c = current_app.config
endpoint = c["KATSU_DATASETS_ENDPOINT"]
response = katsu_get(endpoint, id, query="format=phenopackets")
try:
response = katsu_get(endpoint, id, query="format=phenopackets")
except APIException:
return {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a log warning message or something if this happens, with the APIException contents?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or is this handled in katsu_get

Copy link
Member Author

@gsfk gsfk Apr 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this will be logged already


if "detail" in response and response["detail"] == "Not found.":
return {}

Expand Down