refact(utils): support new Katsu private overview response format #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsfk
requested changes
Apr 12, 2024
There was a problem hiding this comment.
Thanks for starting this one!.
There's some broken stuff here though, since package_biosample_and_experiment_stats() is written with the assumption that katsu private overview has roughly the same format as katsu api/search_overview. See katsu pr for details.
|
updated katsu... should be compatible now |
|
almost there, only thing missing is handling for the extra nesting that's now around experiments |
|
oops |
|
better now, looks good |
gsfk
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.