Features/configure response #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return requested_g | ||
| # if max if "boolean" nothing else is permitted | ||
| if max_g == GRANULARITY_BOOLEAN: | ||
| return max_g |
There was a problem hiding this comment.
so if the user (with boolean access only) requests full records, they get back booleans and not an error? does the spec have an opinion on this or is it a free-for-all?
There was a problem hiding this comment.
Yeah, it's a free-for-all, although I am mostly following the suggestion here in the spec. Since we can do whatever, we could also:
- return 401 Unauthorized (or 400 Bad Request?)
- return as in this pr, but add a message in the response along the lines of "you don't have permissions for this granularity"
I think either of these is fine.
There was a problem hiding this comment.
yeah based on the spec I think this is good then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Requires bento repo changes here to run)
Large refactor of beacon response code.