Features/new auth #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlougheed
requested changes
Oct 17, 2023
bento_beacon/authz/middleware.py
Outdated
| from .utils.beacon_response import build_response_meta | ||
| from ..config_files.config import Config | ||
| from ..utils.beacon_response import build_response_meta | ||
| from .headers import auth_header_getter |
There was a problem hiding this comment.
this import now goes unused
| @@ -0,0 +1,10 @@ | |||
| from flask import request, Request | |||
There was a problem hiding this comment.
this file is just unused stuff, but we could leave it if you intend to do some non-bearer-token stuff in the future
There was a problem hiding this comment.
yeah, it's going to be in the katsu / gohan stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at adding authz to beacon: response to main
/individualsendpoint varies with user permissions:Users without permissions will get the default response only, whether they have a token or not (response currently hardcoded to counts, configurable response coming soon)
The
/individuals/<id>endpoint requires a token with valid permissions, all other users receive 401 / 403.