Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tables #54

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Remove tables #54

merged 2 commits into from
Sep 1, 2023

Conversation

gsfk
Copy link
Member

@gsfk gsfk commented Sep 1, 2023

Remove references to Bento tables.

Gohan /tables was used to verify that elasticsearch was up; when eleasticsearch is down, /variants/overview hangs for a very long time. (I don't see an immediate replacement endpoint to check, ideally it would be /datasets, but that returns nothing).

Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. i think it would just be better if gohan returned an error when ES is down and returned fast; I will create an issue for this for v14

@gsfk
Copy link
Member Author

gsfk commented Sep 1, 2023

lgtm. i think it would just be better if gohan returned an error when ES is down and returned fast; I will create an issue for this for v14

Ah, yeah, that sound good.

@gsfk gsfk merged commit 52bd374 into master Sep 1, 2023
1 check passed
@davidlougheed davidlougheed deleted the remove-tables branch September 5, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants