Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/handle gohan errors #49

Merged
merged 7 commits into from
Jul 31, 2023
Merged

Features/handle gohan errors #49

merged 7 commits into from
Jul 31, 2023

Conversation

gsfk
Copy link
Member

@gsfk gsfk commented Jul 31, 2023

More consistent handling of errors or unexpected responses from gohan /tables endpoint, required for smoother behaviour in bento_public, which needs to be able to tell the difference between:

  • variants missing because of an error
  • variants missing because we don't expect there to be any variants (ie useGohan false)

Also unrelated bonus commit 0b52ff2, fixing an error in beacon response meta.

Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsfk gsfk merged commit aff4cb9 into master Jul 31, 2023
1 check passed
@davidlougheed davidlougheed deleted the features/handle-gohan-errors branch September 5, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants