-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async & concurrent network startup #116
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 59.14% 64.76% +5.62%
==========================================
Files 25 26 +1
Lines 1373 1388 +15
Branches 158 156 -2
==========================================
+ Hits 812 899 +87
+ Misses 494 416 -78
- Partials 67 73 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment which doesn't actually need to be addressed. otherwise from my scan this looks good.
Makes all network calls async