Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async & concurrent network startup #116

Merged
merged 27 commits into from
Nov 27, 2024
Merged

Conversation

gsfk
Copy link
Member

@gsfk gsfk commented Nov 19, 2024

Makes all network calls async

  • main benefit is to beacon network startup, since nodes are now called concurrently
  • update all tests to async
  • a few releated config changes; some deprecated values were also removed

@gsfk gsfk changed the title Features/async calls with auth Async & concurrent network startup Nov 20, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 70.06173% with 97 lines in your changes missing coverage. Please review.

Project coverage is 64.76%. Comparing base (45350d3) to head (716f776).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
bento_beacon/network/utils.py 63.63% 18 Missing and 2 partials ⚠️
bento_beacon/utils/gohan_utils.py 66.66% 15 Missing ⚠️
bento_beacon/utils/handover_utils.py 40.00% 12 Missing ⚠️
bento_beacon/utils/reference.py 21.42% 11 Missing ⚠️
bento_beacon/endpoints/variants.py 10.00% 9 Missing ⚠️
bento_beacon/endpoints/individuals.py 55.55% 8 Missing ⚠️
bento_beacon/utils/katsu_utils.py 87.23% 6 Missing ⚠️
bento_beacon/utils/search.py 42.85% 4 Missing ⚠️
bento_beacon/network/network.py 66.66% 3 Missing ⚠️
bento_beacon/utils/beacon_response.py 76.92% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   59.14%   64.76%   +5.62%     
==========================================
  Files          25       26       +1     
  Lines        1373     1388      +15     
  Branches      158      156       -2     
==========================================
+ Hits          812      899      +87     
+ Misses        494      416      -78     
- Partials       67       73       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsfk gsfk marked this pull request as ready for review November 27, 2024 18:57
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment which doesn't actually need to be addressed. otherwise from my scan this looks good.

bento_beacon/authz/access.py Show resolved Hide resolved
@gsfk gsfk merged commit b6c3fc0 into master Nov 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants