Skip to content

Commit

Permalink
fix: issues caught by testing /service-info
Browse files Browse the repository at this point in the history
  • Loading branch information
davidlougheed committed Feb 12, 2024
1 parent c4916c3 commit 618983d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion bento_aggregation_service/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ async def _git_stdout(*args) -> str:

@application.get("/service-info")
async def service_info(config: ConfigDependency, logger: LoggerDependency):
return build_service_info_from_pydantic_config(
return await build_service_info_from_pydantic_config(
config, logger, {"serviceKind": BENTO_SERVICE_KIND}, SERVICE_TYPE, __version__)
3 changes: 2 additions & 1 deletion bento_aggregation_service/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from functools import lru_cache
from typing import Annotated

from .constants import SERVICE_TYPE
from .constants import SERVICE_NAME, SERVICE_TYPE

__all__ = [
"Config",
Expand All @@ -14,6 +14,7 @@

class Config(BentoBaseConfig):
service_id: str = str(":".join(list(SERVICE_TYPE.values())[:2]))
service_name: str = SERVICE_NAME

request_timeout: int = 180 # seconds

Expand Down

0 comments on commit 618983d

Please sign in to comment.