Fix TSAN warning about unsynchronized access. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces deprecated usage of OSAtomicIncrement32Barrier with an NSLock.
|
Hi, Drew. I was trying to avoid using NSLock (or similar) here because it could involve blocking. ldrex/strex (OSAtomicIncrement32Barrier) is significant faster here. One of the challenges with Swift is the lack of memory order semantics (even having atomic properties!). Your fix definitely works and makes the static analyzer happier, and the implementation that I have cannot be "proven correct" by the analyzer, but works just fine. Is there a way to make TSAN happy without using a blocking lock? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces deprecated usage of OSAtomicIncrement32Barrier with an NSLock.