Add vertical legend to performance dashboard #1517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Performance Dashboard legend and chart become unreadable if you have greater than ~40 job classes
Solution Description
Screenshot of Performance Dashboard
Screenshot of Jobs Dashboard
Shows that there was no regression
Solution Reflections
Implementation Details
vertical: true
plugin option to charts and followed the general guidance in Chart.js HTML Legend to implement a custom legendchart_container
partial which checks for whether the legend is vertical and modifies the layout