Handle continuation HTTP headers correctly #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
http_parser.parser
joins continued header values together as a comma-separated list. According to the RFC continuation lines should instead be joined with a single space:If a header name is repeated, the values can be folded together into a comma-separated list. The current code handles this correctly.
But in either case, if the header value so far is empty, I don't think we should prepend the separator. So this:
Should be equivalent to
Not
I've also attached a couple test suite functions for the continuation and repeated header cases.