refactor(utils): refactor bisectLeft

benji6 · Sep 13, 2024 · ffd8e92 · ffd8e92
1 parent 9ef26c3
commit ffd8e92
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/client/src/utils.test.ts b/client/src/utils.test.ts
@@ -39,7 +39,7 @@ describe("utils", () => {
 
     const testArray = [
       "2015",
-      "2016",
+      "2017",
       "2017",
       "2018",
       "2019",
@@ -53,6 +53,8 @@ describe("utils", () => {
 
     expect(bisectLeft(testArray, "2014")).toBe(0);
     expect(bisectLeft(testArray, "2015")).toBe(0);
+    expect(bisectLeft(testArray, "2016")).toBe(1);
+    expect(bisectLeft(testArray, "2017")).toBe(1);
     expect(bisectLeft(testArray, "2020")).toBe(5);
     expect(bisectLeft(testArray, "2025")).toBe(10);
     expect(bisectLeft(testArray, "2026")).toBe(11);

diff --git a/client/src/utils.ts b/client/src/utils.ts
@@ -8,11 +8,11 @@ import { interpolateHcl } from "d3-interpolate";
 import { removeStopwords } from "stopword";
 
 export const bisectLeft = (xs: string[], x: string, left = 0) => {
-  let right = xs.length - 1;
-  while (left <= right) {
+  let right = xs.length;
+  while (left < right) {
     const mid = Math.floor((left + right) / 2);
     if (xs[mid] < x) left = mid + 1;
-    else right = mid - 1;
+    else right = mid;
   }
   return left;
 };