Remove build.rs #689
Remove build.rs #689
Conversation
|
Where is the unwind feature turned on then? |
When using py-spy as rust library crate, we can enable BTW, there's no code make use of |
|
Yeah but that pull request didn't actually update anything to use the
Yeah that's why it's written as a custom cfg and we'll probably want to revert the feature change and do Alternatively, we need to at least specify the feature per platform during builds. Edit: Looks like @benfred made this change in #691. I don't have strong feelings about which pattern to use. It depends how critical having unwind enabled is, I guess, since people will undoubtably build and test without it enabled accidentally when it's an opt-in feature. |
jiangliu
force-pushed
the
build-rs
branch
24 times, most recently
from
84b25b2
to
2a679f3
Compare
Hi @zanieb, |
src/binary_parser.rs
Outdated
| @@ -19,7 +19,7 @@ pub struct BinaryInfo { | |||
| } | |||
|
|
|||
| impl BinaryInfo { | |||
| #[cfg(feature = "unwind")] | |||
| #[cfg(all(feature = "unwind", target_os = "linux", target_arch = "x86_64"))] | |||
There was a problem hiding this comment.
We also support native unwinding on windows - which I think this might remove.
(also we should probably aim to get in aarch64 / armv7 unwinding on linux in at some point - but that is out of scope of this PR).
There was a problem hiding this comment.
Reverted the change:)
Afeter commit 5820bf6, build.rs has no use anymore, so remove. Signed-off-by: Jiang Liu <[email protected]>
Enable feature `unwind` by default, user can disable it by using: `cargo build --no-default-features` Signed-off-by: Jiang Liu <[email protected]>
Afeter commit 5820bf6, build.rs has no use anymore, so remove.