Bar-shaped resource meter attributes #798
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrates resource meter attributes on items and actors to a schema that FVTT can infer as bar attributes (in other words, they have
value
andmax
).Notes
system.experience
attribute, which doesn't appear to be referenced in our codebase, and is presumably redundant with thesystem.xp
attributeCharacterData
that it uses instead of actually accessing thesystem.momentum.resetValue
andsystem.momentum.max
properties; these will be addressed in Implement impacts/debilities asActiveEffect
s #770Document._addDataFieldMigration
static methodMath
clamp
, because FVTT does the same thing withMath.clamped
. note that this is only applied on files i was already touching to avoid changes to unrelated files