Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar-shaped resource meter attributes #798

Merged
merged 11 commits into from
Jun 9, 2023
Merged

Conversation

rsek
Copy link
Collaborator

@rsek rsek commented Jun 9, 2023

migrates resource meter attributes on items and actors to a schema that FVTT can infer as bar attributes (in other words, they have value and max).

Notes

  • removes the system.experience attribute, which doesn't appear to be referenced in our codebase, and is presumably redundant with the system.xp attribute
  • momentum still has some getters on CharacterData that it uses instead of actually accessing the system.momentum.resetValue and system.momentum.max properties; these will be addressed in Implement impacts/debilities as ActiveEffects #770
  • added stricter typings to the various chat alert handlers
  • added a type augmentation to describe FVTT's Document._addDataFieldMigration static method
  • adds global typings for the augmentations that FVTT provides on Math
  • adds an ESLint rule that forbids using lodash clamp, because FVTT does the same thing with Math.clamped. note that this is only applied on files i was already touching to avoid changes to unrelated files

@rsek rsek marked this pull request as ready for review June 9, 2023 03:49
@rsek rsek merged commit f940425 into ben:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants