-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor + enhance oracle importers for v11 #774
Draft
rsek
wants to merge
43
commits into
ben:main
Choose a base branch
from
rsek:oracle-importers-v11
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #715
The idea here is that dataforged imports should be able to happen without Dataforged living in memory at all times. This implements a method that takes a compendium pack ID and pops a JSON file import dialog. If it can parse that JSON as oracle data, it then proceeds to build the tables (with folders to represent oracle categories) and fill the compendium pack with them.
Note that this PR still loads Dataforged because other stuff (like the oracle tree) relies on it.
RollTables
withOracles
, mainly to serve as a container for a bunch of static methods:Oracles#find
: locates an OracleTable with an ID, UUID, or DFIDOracles#importFromDataforgedDialog
: described above