Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix truths generation #1027

Merged
merged 6 commits into from
Sep 8, 2024
Merged

Fix truths generation #1027

merged 6 commits into from
Sep 8, 2024

Conversation

ben
Copy link
Owner

@ben ben commented Sep 8, 2024 •
edited
Loading

Bug reported in Discord, turns out there was more than one issue here.

  • Prevent editors from emitting after unmount as though they had been chosen (this race was causing the blank outputs)
  • Fix the section titles of Ironsworn truths
  • Fix an [object object] turd in the output
  • Make sure randomize-all and randomize-section work properly
  • Update CHANGELOG.md

@ben ben marked this pull request as ready for review September 8, 2024 15:26
@ben ben merged commit 3cf85f4 into main Sep 8, 2024
0 of 2 checks passed
@ben ben deleted the fix-random-truths branch September 8, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ben