Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to vendor bh php #106

Merged
merged 1 commit into from
Jul 1, 2015
Merged

fix to vendor bh php #106

merged 1 commit into from
Jul 1, 2015

Conversation

un1ko85
Copy link

@un1ko85 un1ko85 commented Apr 10, 2015

No description provided.

@tadatuta
Copy link
Member

cc @zxqfox

@blond blond added the review label Jun 21, 2015
@blond
Copy link
Member

blond commented Jun 30, 2015

@uradvd85, ещё актуально?

@zxqfox можешь посмотреть?

@blond blond added ready and removed review labels Jun 30, 2015
@qfox
Copy link
Member

qfox commented Jul 1, 2015

@blond да, это стоит влить. Мне только не очень нравится отдельная необновляемая ветка.

@tadatuta
Copy link
Member

tadatuta commented Jul 1, 2015

@zxqfox у тебя же права на мерж есть? вливай!
как-нибудь, я надеюсь, @eGavr доберется поддержать bh-php в генераторе (bem-archive/generator-bem-stub#126) и тогда код перекочует туда, а ветку можно будет закрасить.

qfox added a commit that referenced this pull request Jul 1, 2015
@qfox
Merge pull request #106 from uradvd85/patch-1
1568f85 
fix to vendor bh php
@qfox qfox merged commit 1568f85 into bem:php-bem-bh Jul 1, 2015
@levonet levonet removed the ready label Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@un1ko85 @tadatuta @blond @qfox @levonet