-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeline packages #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For simple packages like timeline
and aws-arn
, I think that we are better off using nixpkgs
rather than haskell.nix
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many nits, but this is looking good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this package need to be based on time? It seems like any totally-ordered type would work.
Could we call this continuous-map
or something and remove the dependency on time
?
Co-authored-by: lrworth <[email protected]>
Co-authored-by: lrworth <[email protected]>
Yeah I think if you conceptualise it as a map of non-overlapping intervals but then say in the docs "one common application is timeline data", you get a much more flexible data structure. Something to consider: Do we want to require that the set of intervals completely covers the range of the key type? Certainly in the timeline case we might want to require that, but an interval map with a default value represents a constant function, and then you can quite reasonably build on top of that. |
It's easy to replace In the long run, IMO, |
Merging. If we have anything else to change, let's do that in another PR. |
TODOs
string-interpolate