Reduce developer dependencies to only Docker #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous method for embedding static assets required the installation of the go-bindata and go-bindata-assetfs cli tools. By moving to github.com/shurcooL/vfsgen code generation can now be handled via the `go generate` without any additional dependencies.
By using Docker we no longer need to require developers to have a local installation of Go or understand concepts such as the $GOPATH in order to successfully contribute.
This updates the CI configuration to account for the recent developer experience related changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the development and build setup so that nothing is required of developers other then a working Docker installation. This means developers no longer need to have a working Go development environment or third-party tools such as dep and go-bindata.
The intention is to reduce the overhead for contribution as part of issue #30.