Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor logging tweaks #864

Closed
wants to merge 1 commit into from
Closed

Conversation

cfredri4
Copy link
Contributor

This change makes UnicastHeader/3 toString() consistent with most other headers by wrapping in "[]" And changes two logs for new UNICAST4/NAKACK4 to debug to not be logged by default

This change makes UnicastHeader/3 toString() consistent with most other headers by wrapping in "[]"
And changes two logs for new UNICAST4/NAKACK4 to debug to not be logged by default
@belaban
Copy link
Owner

belaban commented Nov 18, 2024

I don't like the [ and ] braces around the headers, as a matter of fact I removed them from NakackHeader. If we want braces, this should be done uniformly in Headers.printHeaders

@belaban belaban closed this Nov 18, 2024
@belaban
Copy link
Owner

belaban commented Nov 18, 2024

I added Headers.delimiters(String start, String end): you could use Headers.delimiters("[", "]") to use angle brackets for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants