-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.8 support and bump macOS/iOS template epoch #1934
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
838ee0d
Bump pre-commit to Python 3.9
freakboy3742 c97428e
Remove references to Python 3.8 support.
freakboy3742 1d25825
Add platform target versions for iOS and macOS.
freakboy3742 5ead8fb
Add changenotes.
freakboy3742 55d02b1
Apply pyupgrade changes.
freakboy3742 99579d0
Correct tests for Python 3.9 minumum version.
freakboy3742 620b7b6
Use long form for sphinx settings.
freakboy3742 7a36989
Simplify imports of collection types.
freakboy3742 2ab4f5e
Merge branch 'main' into version-bumps
freakboy3742 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -65,7 +65,7 @@ jobs: | |
fail-fast: false | ||
matrix: | ||
platform: [ "macos-12", "macos-14", "windows-latest", "ubuntu-latest" ] | ||
python-version: [ "3.8", "3.12", "3.13-dev" ] | ||
python-version: [ "3.9", "3.12", "3.13-dev" ] | ||
include: | ||
- experimental: false | ||
- platform: "ubuntu-latest" | ||
|
@@ -80,10 +80,6 @@ jobs: | |
# Allow dev Python to fail without failing entire job | ||
- python-version: "3.13-dev" | ||
experimental: true | ||
exclude: | ||
# macos-14 (i.e. arm64) does not support Python 3.8 | ||
- platform: "macos-14" | ||
python-version: "3.8" | ||
steps: | ||
- name: Checkout | ||
uses: actions/[email protected] | ||
|
@@ -145,7 +141,7 @@ jobs: | |
with: | ||
# Use minimum version of python for coverage to avoid phantom branches | ||
# https://github.com/nedbat/coveragepy/issues/1572#issuecomment-1522546425 | ||
python-version: "3.8" | ||
python-version: "3.9" | ||
|
||
- name: Install Tox | ||
uses: beeware/.github/.github/actions/install-requirement@main | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Support for Python 3.8 was dropped. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
macOS and iOS templates have both had an epoch increase. macOS and iOS projects created with previous versions of Briefcase will need to be re-generated. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ dynamic = ["version"] | |
name = "briefcase" | ||
description = "Tools to support converting a Python project into a standalone native application." | ||
readme = "README.rst" | ||
requires-python = ">= 3.8" | ||
requires-python = ">= 3.9" | ||
license.text = "New BSD" | ||
authors = [ | ||
{name="Russell Keith-Magee", email="[email protected]"}, | ||
|
@@ -48,7 +48,6 @@ classifiers = [ | |
"License :: OSI Approved :: BSD License", | ||
"Operating System :: OS Independent", | ||
"Programming Language :: Python :: 3", | ||
"Programming Language :: Python :: 3.8", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
|
@@ -98,9 +97,7 @@ dependencies = [ | |
dev = [ | ||
"coverage[toml] == 7.6.1", | ||
"coverage-conditional-plugin == 0.9.0", | ||
# Pre-commit 3.6.0 deprecated support for Python 3.8 | ||
"pre-commit == 3.5.0 ; python_version < '3.9'", | ||
"pre-commit == 3.8.0 ; python_version >= '3.9'", | ||
"pre-commit == 3.8.0", | ||
"pytest == 8.3.2", | ||
"pytest-xdist == 3.6.1", | ||
"setuptools_scm == 8.1.0", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only substantive logic change required by the version upgrade.
With the move of Sequence from
typing.Sequence
tocollections.abc.Sequence
,SubprocessArgsT
now returns True frominspect.isclass()
, but raises an error if you try to use it inissubclass
. Adding an additional check forinspect.isabstract()
avoids the error, and also allows removing the explicit reference toTool
andManagedTool
classes.