Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update system packages to install in image #19

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Update system packages to install in image #19

merged 1 commit into from
Feb 6, 2024

Conversation

rmartin16
Copy link
Member

Changes

  • Install git so pip can install from local directories
  • Explicitly include pkg-config
  • Remove pwdutils since tumbleweed appears to contain them already

Notes

  • Despite this comment, I cannot find evidence that opensuse/tumbleweed doesn't come with the tools to create a user. Were you using a different image possibly?

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16
Update system packages to install in image
3ade01a 
- Install git so pip can install from local directories
- Explicitly include pkg-config
- Remove pwdutils since tumbleweed appears to contain them already
freakboy3742
freakboy3742 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

As for pwdutils on OpenSUSE - that I can't explain. Testing now, groupadd and useradd definitely appear to be in the image.

Would this be worth backporting to the 0.3.17 branch?

@freakboy3742 freakboy3742 merged commit 0b09bcd into beeware:main Feb 6, 2024
21 checks passed
@rmartin16 rmartin16 deleted the deps branch February 6, 2024 23:50
@rmartin16 rmartin16 restored the deps branch February 6, 2024 23:51
@rmartin16 rmartin16 mentioned this pull request Feb 6, 2024
Merged
4 tasks
@rmartin16 rmartin16 deleted the deps branch February 7, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmartin16 @freakboy3742