Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure apt is always up-to-date before installing #18

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

rmartin16
Copy link
Member

Changes

  • If the SYSTEM_REQUIRES list is updated long after the image is created, then the attempt to install the new requirements may use an out-dated apt cache and will likely error during the install.
  • Ensures apt-get update is always run before an apt install.
  • The other package managers are more sane and only attempt an install with an up-to-date cache.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

- If the `SYSTEM_REQUIRES` list is updated long after the image is
  created, then the attempt to install the new requirements may use an
  out-dated apt cache and will likely error during the install.
- Ensures `apt-get update` is always run before an apt install.
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying that it is required at all, but makes sense.

@freakboy3742 freakboy3742 merged commit a6a6b3b into beeware:main Feb 1, 2024
21 checks passed
@rmartin16 rmartin16 deleted the update-pkg-manager branch February 1, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants