-
-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the BeeWare website - WIP #578
base: lektor
Are you sure you want to change the base?
Conversation
942edce
to
93fc294
Compare
I restructured the Project page as discussed. It looks like a lot of changes, but it's primarily renames, as I had to move everything around to restructure things. Notes:
|
Visit the preview URL for this PR (updated for commit ea4e70a): https://beeware-org--pr578-streamline-beeware-w-h9imfohd.web.app (expires Sun, 11 Aug 2024 01:18:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b0da44bc067e7d9a4255c77cb2c5fce572218cec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely a good first pass at a re-org. The broad structural changes match what we've discussed in Discord; a couple of high-level notes based on poking around:
- I'm not sure about the data mode change introducing the new "important" model. It seems like that model should either (a) be a boolean flag on the existing project model, or (b) an instance of an "important" project type
- The box-and-background-color layout doesn't really work IMHO. I've got some ideas on other possible approaches, but I'm not sure of the best way to share ideas/iterate on mockups of a final layout - open to suggestions on how best to collaborate on this.
- Re-ordering the menubar items. It seems to me that "About" should either come much earlier, or much later (I'd lean towards earlier)
- I'm wondering if the "More" item is actually achieving its desired goal. I guess the intention is to surface more to the top level without crowding the menubar... but it feels a bit like we're still crowding the menu bar, just putting it under a fold. I wonder if, instead of having a "more" item, we move those items under other headings (e.g., say, "code of conduct" under "community"), and then make the other headings pull down menus that provide shortcuts to notable "deep" content.
- I think there's still some re-org potential in the contributions page. The collapse of the depth is great - but the Contribute landing page is now a bit busy and unfocussed.
If you want to catch up for a follow up chat on any of this, I'm at your disposal.
ul.dark-menu .nav-item { | ||
padding: 5px 0 5px 0 !important; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The language selection is already a pulldown, with a style; why do we need a separate style here? (or, if the issue is dark mode vs light mode - why isn't the fix making the language pulldown style dark?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed there was a reason for the background color of the language puilldown, and didn't want to change it. Fixing the language pulldown is a much better solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The language dropdown has been updated to match the rest of the theme.
|
||
.important { | ||
background-color: lightgrey; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not wild about the use of background colours here - it feels really busy, and the box layout doesn't seem to scale well to phone-sized layouts. I wonder if it might be better to stick to a single column with icons on the side, but with bigger icons for the "featured" apps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the page to match this concept. I'll be pushing that update shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it's worth, the background colors were solely for me to differentiate the divs so I knew where everything ended up. They were not necessarily destined for the final product.
@@ -6,7 +6,7 @@ maturity: beta | |||
--- | |||
platforms: macOS, iOS, tvOS, watchOS | |||
--- | |||
project_type: support | |||
project_type: utility | |||
--- | |||
short_description: A meta-package for building a version of Python that can be embedded into a macOS, iOS, tvOS or watchOS project. | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mental note that if we're going to highlight this package (and I think we should), I should probably provide some copy so that this isn't an incomplete stub.
This update addresses only the Project page layout, and the issue with an unnecessary data model being added. I will address the rest of the comments/concerns/suggestions later. |
--- | ||
utilities_description: These are utilities. | ||
--- | ||
utilities_title: Utilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like these fields should be a description on the child project type, rather than specifically enumerated here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't figure out how to make that work this entire time, until I was falling asleep last night, and it clicked. It now uses the information from the category page instead of duplicating it in the Project page.
Replies to your initial notes:
I pushed the update yesterday to match your later suggestion. Please let me know what you think, and if it still doesn't work for you, we can sort out a collaboration method.
I shifted it between "Project" and "Community". Let me know if that works for you or if you want it to come first.
I can work this up and we can see how it feels. I think the way it works right now, the dropdown would always show up when you clicked the page link, as the page loaded, e.g. if you clicked "Community", you would load that page and see the dropdown at the same time. I'll see if I can figure out a different approach if that ends up seeming awkward, such as the dropdown only showing up if you click the arrow next to the page title or something of that nature.
Agreed entirely. I have not taken a pass at this page yet, other than to shift contribution-related things to it.
This would be appreciated. I'll reach out on Discord when I get to a point where it makes sense again. |
The most recent update is a demo of individual existing headers having dropdown menus attached. The way it's done at the moment, the page of the header loads separately from the dropdown, which I think is a necessity. @freakboy3742 Let me know if you like this better than the "More" menu, and we can make use of it where it makes sense moving forward. The current dropdown items are not necessarily where they will end up - I split them up to where they are for the purpose of this demo. |
The most recent update implements collapsing content on the Contributing page, as a potential option for including more information, in a cleaner, less busy way, without loading up another load of subpages. I did not do it for the entire page, as this is simply meant to show what it could look like, if you are interested. |
Definitely better.
I think it makes sense to be first. Unless you're coming to the project already knowing what Toga and Briefcase are, your first questions are likely to be "what is this thing?".
I think the menus work organisationally (better than "more", anyway); but I'm not sure the implementation is quite right. The expansion arrow is a small target, and it took me a couple of tries to get it to work. The i18n dropdown is a "click to open dropdown, click to select target"; I think that might be a better approach for about and community as well.
Yeah - definitely not a fan of expansion for content. IMHO it's the worst of both worlds - requires an extra click to navigate, but doesn't simplify the page when it's visible. |
5e4ade5
to
4f8584b
Compare
4f8584b
to
f4ed371
Compare
@freakboy3742 I have a couple of questions/suggestions before I push the current state of things.
Everything else we discussed is more or less in place and updated. These are a few items we did not discuss, so I wanted to bring them up before continuing. |
I'm not sure about this one. To me, "tools" are the things that you actually touch to do things - so Briefcase might be a tool - but a library or template or support package is something else... it's not really a "tool". The existing text on the project page reinforces that kind of distinction - "BeeWare isn't a single tool or library - it's a collection of projects". To that end "Project" (or maybe "Projects") would seem to be the better fit.
That sounds perfectly reasonable to me - it's nice if we can re-use content when we can, but we don't have to be completely dogmatic about it for the sake of "database minimalism".
Podium is the only application on the current website taxonomy; but Cricket, Bugjar, Duvet, and Galley would all fit under the category of "Application" rather than "Utility" to my mind, as they're end-user apps. That should still leave plenty of content for the utilities page. |
5bb6856
to
a4d8f88
Compare
Redirect script wasn't quite right. Fixing. |
@freakboy3742 This should now be much closer to where we discussed. I've removed the functional menu changes, and moved the discussed items into appropriate locations. The Project page now better reflects your mockup. A couple of notes:
Please take a look when you get a chance, and let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work - this is looking really good. This looks like it's converging on a really solid re-organization of the current website content, without trying to fix the universe in one push.
We're definitely into the "tweaking the minor details" stage - the big structural stuff is looking great. Some things I noticed:
- It looks like pages that had image resources (e.g., Headshot links on /about/team; media resources on /about/contact/media, screenshots on /contributing/first-time/github) are broken; it looks like the body content is pointing to the old image location.
- There's a bunch of links in content to
/community/team
in body content (e.g., on the/about/contact
page). They're all redirecting correctly to the new location; but it should be possible to fix with a search-and-replace. If you've got a list of redirects that you've added, it's likely worth doing a similar search and replace for those. - Some fine tuning of the CSS on the project page is needed. If you compare the layout of the "/project/utilities" page:
The last two points are definitely on the more complex end of the scale; if you don't feel sufficiently confident in your CSS/Lektor wrangling to tackle either of those, let me know, and I'm happy to get my hands dirty. The Lektor one in particular is making my brain melt a bit 😄 - mostly because I need to refresh my memory on how the model, template, and directory structure interact.
|
||
--- | ||
summary: All participants in the BeeWare community are expected to adhere to a Code of Conduct | ||
--- | ||
gutter: | ||
|
||
`Making a Code of Conduct Report </code-of-conduct/making-a-coc-report/>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is renders fine, but the underline is weirdly long, and the link seems to be a 404.
Also, I wonder if it might be better to have the heading not be a link, and add the link to the call to action "Here's how to report the situation".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The /code-of-conduct/...
link is used consistently across this page.
@@ -82,13 +82,13 @@ | |||
</div> | |||
<div class="collapse navbar-collapse" id="navbarsDefault"> | |||
<ul class="navbar-nav mr-auto"> | |||
{{ menu_item('about') }} | |||
{{ menu_item('project') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be Project or Projects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of this model threw me for a bit. It looks almost identical to project-type
; but the name is a lot more "generic". It looks like it might be tied to the historical use of beeware.html
as a template, but that template used to be a lot more generic than it is now.
Hello! This is my initial update to the BeeWare website. It's nowhere near completed but I wanted to get this PR in early for your perusal. So far I've done at least the following:
I did not check the "documented" box below because I did not keep track of everything I did, as many things were merged and separated, and I started to lose track of where it all began. The list above covers most of it, but I'm sure I missed something.
Next steps
That's what I have for now. Cheers!
PR Checklist: