-
-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dependabot to repo #576
Conversation
Visit the preview URL for this PR (updated for commit bcd8bb1): https://beeware-org--pr576-dependabot-d5qvtlq7.web.app (expires Thu, 18 Jul 2024 03:05:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b0da44bc067e7d9a4255c77cb2c5fce572218cec |
Since I'm curious :) is the intention to bump these requirements? If so, you may want to remove this comment in requirements.txt? FWIW, I'm not actually sure if Dependabot will assume a arbitrary requirements.txt file contains Python packages...but it does make sense I think... beeware.github.io/requirements.txt Lines 1 to 23 in 8ac4624
|
Yes, that's the intention (or, at least, to use the same update scheme that we use on other repos).
Everything below that line is pinning the full dependency tree. We've had some historical issues because of the interplay of dependencies between lektor, jinja, and a variety of other packages that have some weird dependencies chains. So - everything above the line is stuff we're explicitly depending on; everything below are the versions that are implied, but need to be pinned to prevent dependency chaos. It's effectively a lockfile, but without adopting a lockfile syntax. The comment won't stop being true as a result of moving to dependabot; we'll just be doing more aggressive updates over time.
According to the docs, it will - the |
As it stands, this will result in Dependabot generating updates for 21 packages instead of only 2. Surely you don't want to deal with that every Monday. If these "historical issues" have been resolved, then the pins can be removed. If they haven't been resolved, then the pins should be reduced to the minimal set required, and a comment added explaining exactly why they're necessary, so we'll know when it's safe to remove them. |
That's a fair point. We're not really exposed to any security issues here, as it's a static site generator; manually updating the pins if/when need arises will be just as viable as continuously updating. Closing. |
For posterity, there's still the |
In the process of investigating #575, it was revealed that dependabot wasn't configured for this repository.
This PR adds specific version pins for the GitHub Actions in use, and enables dependabot weekly updates for actions and pip. It also updates the runtime to use Python 3.12, rather than 3.7.
PR Checklist: