Make button row 11 columns wide at small viewports. #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 0a78d66): https://beeware-org--pr560-home-page-button-wid-plu068wj.web.app (expires Wed, 24 Apr 2024 00:36:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b0da44bc067e7d9a4255c77cb2c5fce572218cec |
freakboy3742
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause of #559 was the row the buttons are embedded in are col-sm-8, which is too thin in some breakpoints for the width of the the button. I tested a few other column widths, 10 was too thin at the 554 breakpoint. 12 is full width at all sizes. 11 works at all.
Happy to switch to 12 if that is preferred.
Reported as #559, the "Contribute to BeeWare" button was too narrow at a variety of breakpoints. This makes it wide enough for the text at all the major breakpoints.
Fixes #559
PR Checklist: