Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add releasegroupdisambig MediaField #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add releasegroupdisambig MediaField #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b0b227
Add releasegroupdisambig MediaField
Moonbase59 Sep 29, 2019
03e0818
Add releasegroupdisambig to unit tests
Moonbase59 Sep 29, 2019
7dbeafe
Correct line too long
Moonbase59 Sep 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions mediafile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1843,6 +1843,14 @@ def update(self, dict):
StorageStyle('MUSICBRAINZ_ALBUMCOMMENT'),
ASFStorageStyle('MusicBrainz/Album Comment'),
)
releasegroupdisambig = MediaField(
# This tag mapping was invented for beets (not used by Picard, etc).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just say "As above." or something instead of duplicating the text?

MP3DescStorageStyle(u'MusicBrainz Release Group Comment'),
MP4StorageStyle('----:com.apple.iTunes:MusicBrainz '
'Release Group Comment'),
StorageStyle('MUSICBRAINZ_RELEASEGROUPCOMMENT'),
ASFStorageStyle('MusicBrainz/Release Group Comment'),
)

# Release date.
date = DateField(
Expand Down
1 change: 1 addition & 0 deletions test/test_mediafile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ class ReadWriteTestBase(ArtTestMixin, GenreListTestMixin,
'albumstatus',
'media',
'albumdisambig',
'releasegroupdisambig',
'artist_credit',
'albumartist_credit',
'original_year',
Expand Down