Skip to content

Commit

Permalink
modify comment to better reflect what this fix does
Browse files Browse the repository at this point in the history
  • Loading branch information
bedroge committed Oct 29, 2024
1 parent da3593f commit 60633b0
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions easybuild/easyblocks/s/score_p.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,8 @@ def configure_step(self, *args, **kwargs):
"""Configure the build, set configure options for compiler, MPI and dependencies."""

if LooseVersion(self.version) >= LooseVersion('8.0') and LooseVersion(self.version) < LooseVersion('8.5'):
# Let configure scripts specifically check for yes|no instead of *yes*|*no*,
# to prevent errors for certain dependencies installed in a path that includes "yes" or "no"
# see https://gitlab.com/score-p/scorep/-/issues/1008
# Fix an issue where the configure script would fail if certain dependencies are installed in a path
# that includes "yes" or "no", see https://gitlab.com/score-p/scorep/-/issues/1008.
yes_no_regex = [
(r'\*yes\*\|\*no\*', 'yes,*|no,*|*,yes|*,no'),
(r'_lib}\${with_', '_lib},${with_'),
Expand Down

0 comments on commit 60633b0

Please sign in to comment.