Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcluster]: fix - use ServerSideApply for lifecycle tasks #144

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

adberger
Copy link
Contributor

What this PR does:

Only using kubectl apply can result in an error if the changes are too big:
The CustomResourceDefinition "thanosrulers.monitoring.coreos.com" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

@adberger adberger requested a review from a team as a code owner December 18, 2024 21:08
@adberger adberger requested a review from malahayatii December 18, 2024 21:08
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2024
@adberger adberger merged commit 5f8dabf into bedag:master Dec 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant