Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common]: support for defining multiple hosts for an Ingress #138

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wthhub
Copy link
Contributor

@wthhub wthhub commented Oct 30, 2024

What this PR does: This PR enhances the common chart with the ability to define multiple hosts (with and without existing secrets) for one single ingress.

Notes for Reviewer:

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

@wthhub wthhub requested a review from a team as a code owner October 30, 2024 14:05
@wthhub wthhub requested a review from brjos October 30, 2024 14:05
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2024
@wthhub wthhub force-pushed the feat/add-multiple-hosts-for-ingress branch from c060db7 to 8a22314 Compare October 30, 2024 14:08
@wthhub wthhub removed the request for review from brjos October 30, 2024 14:10
Signed-off-by: Thomas Wessner <[email protected]>
@wthhub wthhub force-pushed the feat/add-multiple-hosts-for-ingress branch from 8a22314 to 2eee6fc Compare October 30, 2024 14:20
Signed-off-by: Thomas Wessner <[email protected]>
@wthhub wthhub requested a review from fanks4 October 31, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant