Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common]: Allows annotations on pvcs #136

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[common]: Allows annotations on pvcs #136

wants to merge 2 commits into from

Conversation

ytsurk
Copy link

@ytsurk ytsurk commented Oct 8, 2024 •
edited
Loading

What this PR does:

Which issue this PR fixes fixes #135

Notes for Reviewer:

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

@ytsurk ytsurk requested a review from a team as a code owner October 8, 2024 09:24
@ytsurk ytsurk requested a review from ln-ro October 8, 2024 09:24
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2024
@ytsurk ytsurk changed the title Master [common] Allows annotations on pvcs Oct 8, 2024
@ytsurk ytsurk force-pushed the master branch 6 times, most recently from b128e16 to 95e6c71 Compare October 8, 2024 21:14
lichtloescher
lichtloescher requested changes Oct 10, 2024
View reviewed changes
Copy link

@lichtloescher lichtloescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also bump the chart version?

https://github.com/bedag/helm-charts/blob/master/charts/common/Chart.yaml

@ytsurk ytsurk force-pushed the master branch 4 times, most recently from 086a2ad to 3f4310f Compare October 13, 2024 18:56
@ytsurk
Copy link
Author

ytsurk commented Oct 13, 2024

Done. Did not expect a straight release ;)

@ytsurk ytsurk changed the title [common] Allows annotations on pvcs [common]: Allows annotations on pvcs Oct 15, 2024
@wthhub
Copy link
Contributor

wthhub commented Oct 21, 2024

Thank you for your contribution, the functional part is fine!
Could you please extend the schema in values.schema.json to reflect the changes and also add an example of the new values in values.yaml? This will help ensure that everything is documented correctly and improves the user experience.

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichtloescher lichtloescher lichtloescher requested changes

@ln-ro ln-ro Awaiting requested review from ln-ro ln-ro is a code owner automatically assigned from bedag/sre

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[common] Allowing annotations on persistent volume claims
3 participants
@ytsurk @wthhub @lichtloescher