Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common]: making multiple ingress objects possible #134

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

ln-ro
Copy link
Contributor

@ln-ro ln-ro commented Oct 7, 2024

What this PR does: This PR enhances the common chart with the ability to include multiple ingress objects, e.g. to have different annotations

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Notes for Reviewer:

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

@ln-ro ln-ro requested a review from a team as a code owner October 7, 2024 06:36
@ln-ro ln-ro requested a review from adberger October 7, 2024 06:36
@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 7, 2024
@ln-ro ln-ro requested review from fanks4 and removed request for adberger October 7, 2024 11:43
@ln-ro ln-ro merged commit e9f6752 into master Oct 7, 2024
4 checks passed
@ln-ro ln-ro deleted the feat/ingresses branch October 7, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants