Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common]: add envfrom #115

Merged
merged 4 commits into from
Sep 18, 2023
Merged

[common]: add envfrom #115

merged 4 commits into from
Sep 18, 2023

Conversation

oliverbaehler
Copy link
Contributor

@oliverbaehler oliverbaehler commented Sep 18, 2023 •
edited by adberger
Loading

What this PR does:
Allows to specify custom envFrom for all container components.

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

@oliverbaehler oliverbaehler requested a review from a team as a code owner September 18, 2023 10:34
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 18, 2023
adberger
adberger reviewed Sep 18, 2023
View reviewed changes
charts/common/values.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2023
adberger
adberger approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@adberger adberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@oliverbaehler oliverbaehler merged commit 43bdc6a into master Sep 18, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adberger adberger adberger approved these changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverbaehler @adberger