Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common] fix: quote extraLabel value #108

Merged
merged 1 commit into from
Aug 7, 2023
Merged

[common] fix: quote extraLabel value #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/common/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: common
description: "Bedag's common Helm chart to use for creating other Helm charts"
version: 10.3.0
version: 10.3.1
# A chart can be either an 'application' or a 'library' chart.
#
# Application charts are a collection of templates that can be packaged into versioned archives
Expand Down
2 changes: 1 addition & 1 deletion charts/common/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# common

![Version: 10.3.0](https://img.shields.io/badge/Version-10.3.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
![Version: 10.3.1](https://img.shields.io/badge/Version-10.3.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

Bedag's common Helm chart to use for creating other Helm charts

Expand Down
2 changes: 1 addition & 1 deletion charts/common/templates/_cronjob.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
{{ include "library.labels.stable" $root | indent 8 }}
app.kubernetes.io/component: {{ $name }}
{{- range $key, $value := $cronjob.extraLabels }}
{{ $key }}: {{ $value }}
{{ $key }}: {{ $value | quote }}
{{- end }}
{{- if $cronjob.gatherMetrics }}
gatherMetrics: "enabled"
Expand Down
2 changes: 1 addition & 1 deletion charts/common/templates/_deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ spec:
{{ include "library.labels.stable" $root | indent 8 }}
app.kubernetes.io/component: {{ $name }}
{{- range $key, $value := $deployment.extraLabels }}
{{ $key }}: {{ $value }}
{{ $key }}: {{ $value | quote }}
{{- end }}
{{- if $deployment.gatherMetrics }}
gatherMetrics: "enabled"
Expand Down
2 changes: 1 addition & 1 deletion charts/common/templates/_jobspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ template:
{{ include "library.labels.stable" $root | indent 6 }}
app.kubernetes.io/component: {{ $name }}
{{- range $key, $value := $job.extraLabels }}
{{ $key }}: {{ $value }}
{{ $key }}: {{ $value | quote }}
{{- end }}
{{- if $job.gatherMetrics }}
gatherMetrics: "enabled"
Expand Down
2 changes: 1 addition & 1 deletion charts/common/templates/_statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
{{ include "library.labels.stable" $root | indent 8 }}
app.kubernetes.io/component: {{ $name }}
{{- range $key, $value := $statefulset.extraLabels }}
{{ $key }}: {{ $value }}
{{ $key }}: {{ $value | quote }}
{{- end }}
{{- if $statefulset.gatherMetrics }}
gatherMetrics: "enabled"
Expand Down
Loading