Merge pull request #22 from oliverbaehler/master

[manifests]: Fixed Cronjob Bugs

CONTRIBUTING.md

@@ -167,24 +167,18 @@ annotations:
 
 ### Changelog
 
-Changes on a chart must be documented in a chart specific changelog. For every new release the entire ```artifacthub.io/changes``` needs to be rewritten. Please use the following template:
+Changes on a chart must be documented in a chart specific changelog. For every new release the entire artifacthub.io/changes needs to be rewritten. Each change requires a new bullet point following the pattern **[{type}]**: {description}. Please use the following template:
 
 
 ```
 artifacthub.io/changes: |
-  **Added:**
-    * Added something within this chart
-  **Changed:**
-    * Changed Something within this chart
-    * Changed Something else within this chart
-  **Deprecated:**
-    * None
-  **Removed:**
-    * None
-  **Fixed:**
-    * Some Bug was fixed
-  **Security:**
-    * None
+  * **[Added]**: Something New was added
+  * **[Changed]**: Changed Something within this chart
+  * **[Changed]**: Changed Something else within this chart
+  * **[Deprecated]**: Something deprecated
+  * **[Removed]**: Something was removed
+  * **[Fixed]**: Something was fixed
+  * **[Security]**: Some Security Patch was included
 ```
 
 # Workflows

charts/manifests/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 name: manifests
 description: "Bedag's Manifest chart. Library full of basic kubernetes manifests."
 type: library
-version: 0.4.3
+version: 0.4.4
 icon: "https://www.bedag.ch/wGlobal/wGlobal/layout/images/logo.svg"
 keywords:
 - Bedag
@@ -21,15 +21,5 @@ annotations:
   artifacthub.io/containsSecurityUpdates: "false"
   artifacthub.io/prerelease: "true"
   artifacthub.io/changes: |
-    **Added:**
-      * None
-    **Changed:**
-      * Dependency `library` latest version
-    **Deprecated:**
-      * None
-    **Removed:**
-      * None
-    **Fixed:**
-      * [manifest/horizontalPodAutoscaler]: Metrics must be set for manifest to be returned
-    **Security:**
-      * None
+    * **[Fixed]**: Cronjob render correct manifest structure
+    * **[Fixed]**: Cronjob use Default API `batch/v1beta1`

charts/manifests/README.md

@@ -1,6 +1,6 @@
 # Manifests Library
 
-![Version: 0.4.3](https://img.shields.io/badge/Version-0.4.3-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square)
+![Version: 0.4.4](https://img.shields.io/badge/Version-0.4.4-informational?style=flat-square) ![Type: library](https://img.shields.io/badge/Type-library-informational?style=flat-square)
 
 This library's purpose is to have more flexibility as chart author but at the same time have kubernetes manifests managed in a central library. This way you can avoid big surprises when Kubernetes has breaking changes in any of their APIs. Currently we support a base set of resources. Resources may be added as soon as we see or get a request that there's a need for it. This chart is still under development and testing, since it's rather complex. Feel free to use it. Our goal is to get it as reliable as possible.
 

charts/manifests/templates/manifests/_cronjob.tpl

@@ -28,7 +28,7 @@ kind: CronJob
       {{- if $cronjob.apiVersion }}
 apiVersion: {{ $cronjob.apiVersion }}
       {{- else }}
-apiVersion: batch/v1
+apiVersion: batch/v1beta1
       {{- end }}
 metadata:
   name:  {{ include "bedag-lib.utils.common.fullname" . }}
@@ -46,8 +46,7 @@ spec:
   startingDeadlineSeconds: {{ $cronjob.startingDeadlineSeconds }}
   successfulJobsHistoryLimit: {{ $cronjob.successfulJobsHistoryLimit }}
   suspend: {{ $cronjob.suspend }}
-  jobTemplate:
-    spec: {{- include "bedag-lib.template.job" (set . "job" $cronjob) | nindent 6 }}
+  jobTemplate: {{- include "bedag-lib.template.job" (set . "job" $cronjob) | nindent 4 }}
     {{- end }}
   {{- end }}
 {{- end -}}