Merge pull request #108 from brjos/master

[common] fix: quote extraLabel value
bedag · Aug 7, 2023 · 9ca5bf2 · 9ca5bf2
2 parents fc17db5 + e974446
commit 9ca5bf2
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/charts/common/Chart.yaml b/charts/common/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v2
 name: common
 description: "Bedag's common Helm chart to use for creating other Helm charts"
-version: 10.3.0
+version: 10.3.1
 # A chart can be either an 'application' or a 'library' chart.
 #
 # Application charts are a collection of templates that can be packaged into versioned archives

diff --git a/charts/common/README.md b/charts/common/README.md
@@ -1,6 +1,6 @@
 # common
 
-![Version: 10.3.0](https://img.shields.io/badge/Version-10.3.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
+![Version: 10.3.1](https://img.shields.io/badge/Version-10.3.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
 
 Bedag's common Helm chart to use for creating other Helm charts
 

diff --git a/charts/common/templates/_cronjob.yaml b/charts/common/templates/_cronjob.yaml
@@ -33,7 +33,7 @@ spec:
 {{ include "library.labels.stable" $root | indent 8 }}
         app.kubernetes.io/component: {{ $name }}
         {{- range $key, $value := $cronjob.extraLabels }}
-        {{ $key }}: {{ $value }}
+        {{ $key }}: {{ $value | quote }}
         {{- end }}
         {{- if $cronjob.gatherMetrics }}
         gatherMetrics: "enabled"

diff --git a/charts/common/templates/_deployment.yaml b/charts/common/templates/_deployment.yaml
@@ -40,7 +40,7 @@ spec:
 {{ include "library.labels.stable" $root | indent 8 }}
         app.kubernetes.io/component: {{ $name }}
         {{- range $key, $value := $deployment.extraLabels }}
-        {{ $key }}: {{ $value }}
+        {{ $key }}: {{ $value | quote }}
         {{- end }}
         {{- if $deployment.gatherMetrics }}
         gatherMetrics: "enabled"

diff --git a/charts/common/templates/_jobspec.yaml b/charts/common/templates/_jobspec.yaml
@@ -27,7 +27,7 @@ template:
 {{ include "library.labels.stable" $root | indent 6 }}
       app.kubernetes.io/component: {{ $name }}
       {{- range $key, $value := $job.extraLabels }}
-      {{ $key }}: {{ $value }}
+      {{ $key }}: {{ $value | quote }}
       {{- end }}
       {{- if $job.gatherMetrics }}
       gatherMetrics: "enabled"

diff --git a/charts/common/templates/_statefulset.yaml b/charts/common/templates/_statefulset.yaml
@@ -30,7 +30,7 @@ spec:
 {{ include "library.labels.stable" $root | indent 8 }}
         app.kubernetes.io/component: {{ $name }}
         {{- range $key, $value := $statefulset.extraLabels }}
-        {{ $key }}: {{ $value }}
+        {{ $key }}: {{ $value | quote }}
         {{- end }}
         {{- if $statefulset.gatherMetrics }}
         gatherMetrics: "enabled"