Merge pull request #111 from adberger/master

[common] Add ability to add external pvcs to pods
bedag · Aug 18, 2023 · 6b22d5a · 6b22d5a
2 parents c0cdb7a + 106efc2
commit 6b22d5a
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 3 deletions.
diff --git a/charts/common/Chart.yaml b/charts/common/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v2
 name: common
 description: "Bedag's common Helm chart to use for creating other Helm charts"
-version: 10.3.2
+version: 10.4.0
 # A chart can be either an 'application' or a 'library' chart.
 #
 # Application charts are a collection of templates that can be packaged into versioned archives

diff --git a/charts/common/README.md b/charts/common/README.md
@@ -1,6 +1,6 @@
 # common
 
-![Version: 10.3.2](https://img.shields.io/badge/Version-10.3.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
+![Version: 10.4.0](https://img.shields.io/badge/Version-10.4.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
 
 Bedag's common Helm chart to use for creating other Helm charts
 

diff --git a/charts/common/templates/_pod.yaml b/charts/common/templates/_pod.yaml
@@ -79,6 +79,14 @@ volumes:
     {{- else }}
     emptyDir: {}
     {{- end }}
+  {{- else if eq .type "external" }}
+    {{- if .pvcName }}
+    persistentVolumeClaim:
+      claimName: {{ .pvcName }}
+      {{- if .readOnly }}
+      readOnly: {{ .readOnly }}
+      {{- end }}
+    {{- end }}
   {{- end }}
   {{- end }}
   {{- end }}

diff --git a/charts/common/values.yaml b/charts/common/values.yaml
@@ -425,7 +425,7 @@ components:
       volumes: []
       #   -- name of the volume
       # - name: generic-name
-      #   -- type can either be "secret", "configMap", "persistentVolumeClaim" or "emptyDir"
+      #   -- type can either be "secret", "configMap", "persistentVolumeClaim", "emptyDir" or "external"
       #    type: "secret"
       #   START ONLY FOR SECRET or CONFIGMAP
       #   filePath is optional for specifying a filePath in the helm chart where the file is located.
@@ -445,6 +445,12 @@ components:
       #   sizeLimit is the total amount of local storage required for this EmptyDir volume. Default is nil which means that the limit is undefined.
       #    sizeLimit: 100Mi
       #   END ONLY FOR EMPTYDIR
+      #   START ONLY FOR EXTERNAL
+      #   pvcName represents what name the external existing PVC has.
+      #    pvcName: "foo"
+      #   readOnly will force the ReadOnly setting in VolumeMounts. Comment out for using default (false)
+      #    readOnly: true
+      #   END ONLY FOR EXTERNAL
       # end pod
 
       # start containers