Skip to content

Commit

Permalink
Merge pull request #143 from adberger/master
Browse files Browse the repository at this point in the history
[vcluster]: chore - switch dependency to oci helm chart
  • Loading branch information
adberger authored Dec 16, 2024
2 parents 77899ab + 37305bd commit 09ff749
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
python-version: "3.10"

- name: Set up chart-testing
uses: helm/chart-testing-action@v2.7.0
uses: helm/chart-testing-action@v2.6.1

- name: Run chart-testing (list-changed)
id: list-changed
Expand Down
16 changes: 8 additions & 8 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,20 @@
repos:

- repo: https://github.com/pre-commit/pre-commit-hooks.git
rev: v4.3.0
rev: v5.0.0
hooks:
- id: end-of-file-fixer
exclude_types: ['markdown']
stages: [commit]
stages: [pre-commit]
- id: trailing-whitespace
exclude_types: ['markdown']
stages: [commit]
stages: [pre-commit]
- id: mixed-line-ending
stages: [commit]
stages: [pre-commit]
- id: check-byte-order-marker
stages: [commit]
stages: [pre-commit]
- id: check-executables-have-shebangs
stages: [commit]
stages: [pre-commit]
- id: check-merge-conflict

- repo: local
Expand All @@ -26,11 +26,11 @@ repos:
args: ["helm-docs"]
language: system
pass_filenames: false
stages: [commit]
stages: [pre-commit]
- id: ct-lint
name: ct-lint
entry: make
args: ["helm-lint"]
language: system
pass_filenames: false
stages: [commit]
stages: [pre-commit]
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
# Helm
SRC_ROOT = $(shell git rev-parse --show-toplevel)

helm-docs: HELMDOCS_VERSION := v1.11.0
helm-docs: HELMDOCS_VERSION := v1.14.2
helm-docs: docker
@docker run -v "$(SRC_ROOT):/helm-docs" jnorwood/helm-docs:$(HELMDOCS_VERSION) --chart-search-root /helm-docs

helm-lint: CT_VERSION := v3.3.1
helm-lint: CT_VERSION := v3.11.0
helm-lint: docker
@docker run -v "$(SRC_ROOT):/workdir" --entrypoint /bin/sh quay.io/helmpack/chart-testing:$(CT_VERSION) -c "cd /workdir; ct lint --config ct.yaml --lint-conf lintconf.yaml --all --debug"

Expand Down
2 changes: 1 addition & 1 deletion charts/vcluster/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ maintainers:
dependencies:
- name: common
version: 2.14.1
repository: https://charts.bitnami.com/bitnami
repository: oci://registry-1.docker.io/bitnamicharts
2 changes: 1 addition & 1 deletion charts/vcluster/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Virtual Kubernetes Cluster

| Repository | Name | Version |
|------------|------|---------|
| https://charts.bitnami.com/bitnami | common | 2.14.1 |
| oci://registry-1.docker.io/bitnamicharts | common | 2.14.1 |

# Major Changes

Expand Down
3 changes: 2 additions & 1 deletion ct.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@ chart-dirs:
chart-repos:
- buttahtoast=https://buttahtoast.github.io/helm-charts/
- bedag=https://bedag.github.io/helm-charts/
- bitnami=https://charts.bitnami.com/bitnami
# - bitnami=registry-1.docker.io/bitnamicharts
validate-chart-schema: true
validate-maintainers: false
validate-yaml: true
exclude-deprecated: true
excluded-charts:
- "manifests"
- "vcluster"

0 comments on commit 09ff749

Please sign in to comment.