Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic parser rewrite #138

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Topic parser rewrite #138

wants to merge 24 commits into from

Conversation

cycomachead
Copy link
Member

Merge in peter's work!

// LLAB selectors for common page elements
llab.selectors.FULL = '.full';
llab.selectors.NAVSELECT = '.llab-nav';
llab.selectors.PROGRESS = '.full-bottom-bar';
llab.selectors.NAVTITLE = '.navbar-title';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

line = lines[i];
line = llab.stripComments(line);
// TODO: Refactor this line
isHidden = params.hasOwnProperty('no' + $.trim(line.slice(0, line.indexOf(':'))));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long.
Mixed double and single quotes.

@cycomachead cycomachead self-assigned this May 23, 2015
}

llab.isKeyword = function(line) {
return llab.isResource(line) || llab.isInfo(line) || llab.isHeading(line);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.
Too many errors. (48% scanned).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants