Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add css improvements for journal on mobile devices #1817

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

dtrai2
Copy link
Contributor

@dtrai2 dtrai2 commented May 28, 2024

Hi I just tried to improve the mobile view of journals. You can consider this PR as a proposal to improve the look and feel, so any feedback and remarks are welcome!

My issue with the current look and feel is that it is difficult to read what is actually going on. For example like this:

The narrations and the payees are often shortened with ....

My suggestion would be to give the rows a second line. The first line has the date, flag, indicators and the prices, while in the second line it has the narrations or the accounts:

As seen in the screenshot: budgets are not perfect yet, but it's a start.
What do you think about that?

@pwalkr
Copy link

pwalkr commented Jun 6, 2024

The expanded postings look much better without the left-side margin from the date column. What about margins in the account view? The icons to expand postings shouldn't need more than 1-2 dots to get the idea, it seems like the change and balance fields could stay on the same line:
account

@dtrai2
Copy link
Contributor Author

dtrai2 commented Jun 6, 2024

Yes thanks for the hints. It does still need some work, and I'll continue with it. I just wanted to wait a bit for feedback before I start working in a direction that is not favored.

@dtrai2 dtrai2 force-pushed the improve-mobile-journal-view branch from 32f1ad8 to 1c34584 Compare October 19, 2024 16:40
@yagebu
Copy link
Member

yagebu commented Oct 22, 2024

My suggestion would be to give the rows a second line. The first line has the date, flag, indicators and the prices, while in the second line it has the narrations or the accounts:

Yeah, I guess something like expanding it to two lines is needed on very small screens. The full color version is a bit too colorful in my opinion - could you try reducing that to maybe just having one of the cells colored (or some colored border maybe?)?

I definitely like the changed postings display, removing that left indent is a very good idea.

@dtrai2
Copy link
Contributor Author

dtrai2 commented Nov 1, 2024

thanks for the feedback! I had a try at the postings and the alignments now, and I also removed again the colors highlighting the full row. let me know what you think and if there is something else I should have a look at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants