Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update torndb.py #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update torndb.py #13

wants to merge 2 commits into from

Conversation

learsu
Copy link

@learsu learsu commented Jul 31, 2013

support transaction,no false reason,if you want reason,del L149 #

learsu added 2 commits July 31, 2013 16:34
support transaction,no false reason,if you want reason,del L149 #
method _ensure_connected add ping check connect
@felix021
Copy link

The reconnect() call you added may conflict will the transaction feature.

The comments in libmysql/client.c says:

By default we don't reconnect because it could silently corrupt data (after reconnection you potentially lose table locks, user variables, session variables (transactions but they are specifically dealt with in mysql_reconnect()). This is a change: < 5.0.3 mysql->reconnect was set to 1 by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants