Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for Amazon Linux 2 #178

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding support for Amazon Linux 2 #178

wants to merge 2 commits into from

Conversation

justinas-b
Copy link

No description provided.

bdangit
bdangit requested changes Apr 6, 2019
View reviewed changes
Copy link
Owner

@bdangit bdangit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good so far. Can you check out my comment?

metadata.rb Show resolved Hide resolved
bdangit
bdangit approved these changes Apr 21, 2019
View reviewed changes
Copy link
Owner

@bdangit bdangit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

metadata.rb Show resolved Hide resolved
bdangit
bdangit requested changes Apr 21, 2019
View reviewed changes
Copy link
Owner

@bdangit bdangit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit. Can you please squash commits?

@bdangit
Copy link
Owner

bdangit commented Sep 1, 2019

gentle reminder for @justinas-b. Can you please squash commits and then we'll be okay to merge.

@justinas-b
Copy link
Author

Hi @bdangit, sorry but it seems I have lost my forked repo, so I am unable to do the squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdangit bdangit bdangit requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinas-b @bdangit