Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fatfree app and test to support namespace F3 update made to fatfree-core in #112. #901

Closed
wants to merge 1 commit into from
Closed

Update fatfree app and test to support namespace F3 update made to fatfree-core in #112. #901

wants to merge 1 commit into from

Conversation

sgpinkus
Copy link

All references to fatfree-core now prefixed with vendor namespace "F3". Please refer to f3-factory/fatfree-core#110.

Note fatfree-core directory has moved from lib to f3, just because it just worked with the existing f3 autoloader. Submodule references also needs to be updated, but need a commit to reference before that can be done.

@sgpinkus
Copy link
Author

BTW to test this:

git clone -b namespace-fatfree-core https://github.com/sam-at-github/fatfree
cd fatfree/
git rm -rf f3/
git submodule add -b namespace-fatfree https://github.com/sam-at-github/fatfree-core f3
php index.php # or setup HTTP server to serve cwd.

@ikkez
Copy link
Collaborator

ikkez commented Nov 4, 2022

solved in v4 test app

@ikkez ikkez closed this Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants