Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error listings for unit tests #837

Closed
wants to merge 1 commit into from
Closed

Conversation

Rayne
Copy link
Contributor

@Rayne Rayne commented May 31, 2015

This PR adds error listings above the unit test results, which makes it easier to spot failed tests (not only for people with red-green color blindness). Also it looks quite nice.

Depends on PR f3-factory/fatfree-core#64.

This PR adds error listings above the unit test results, which makes it easier to spot failed tests (not only for people with red-green color blindness). Also it looks quite nice.

Depends on PR f3-factory/fatfree-core#64.
@xfra35
Copy link
Collaborator

xfra35 commented Jun 1, 2015

Hi @Rayne,

I agree that a quicker reading of the results could be achieved but I'm not convinced by this PR because:

I think we could achieve the same result with a simple counter or a check mark at the title level or just below.

But what would be really awesome would be to print the test results for all the pages directly in the left sidebar =)

@Rayne
Copy link
Contributor Author

Rayne commented Jun 1, 2015

Thank you @xfra35. The counter or the check mark are good ideas for a first look. But spotting the exact error (without reading test descriptions) in your check mark example is still difficult (for me). Another or additional idea: let error descriptions be bold (not italic, it doesn't jump in your face when looking at a list of tests).

You are also right that the PR is not essential for this feature. I also understand that you don't like that errors get reported twice. I duplicated them, so it's still possible to study the development of tests building up on previous tests.

I doubt that it's possible to print the result for all pages. For instance the OpenID tests depend on user interactions. With some help of JavaScript (instead of executing all tests for every request at once), it should be possible to get the results of the remaining tests.

It could look like:

  • Globals [✓]
  • Internals [✓]
  • ThisTestHasFailures [3]

We could also hide debug information, when there are no errors:

  • Globals
  • Internals
  • ThisTestHasFailures [3]

@xfra35
Copy link
Collaborator

xfra35 commented Jun 1, 2015

I didn't pay attention to your commit message. You're right about color blindness. So maybe we could enhance the CSS to add a validate/fail mark symbol before each test?

@Rayne
Copy link
Contributor Author

Rayne commented Jun 2, 2015

A simple status symbol will not jump in your face when skimming the test descriptions, but would be a first step in the right direction. What do you think about failed tests in bold? Another idea:

example

@Rayne Rayne closed this Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants