Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade bcrypto to 5.4.0 #1009

Closed
wants to merge 2 commits into from
Closed

upgrade bcrypto to 5.4.0 #1009

wants to merge 2 commits into from

Conversation

bizmindx
Copy link

@bizmindx bizmindx commented Mar 4, 2021

bumps bcrypto version from 5.0.4 to 5.4.0

fixes related when running on OSX 10.15
56
55

@codecov-io
Copy link

Codecov Report

Merging #1009 (0e6555b) into master (f1abba5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1009   +/-   ##
=======================================
  Coverage   62.46%   62.46%           
=======================================
  Files         156      156           
  Lines       26082    26082           
=======================================
  Hits        16293    16293           
  Misses       9789     9789           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1abba5...0e6555b. Read the comment docs.

@pinheadmz
Copy link
Member

Thanks for reporting. Actually since we are committing all node_modules in this repo now -- I think this kind of PR should also include the entire update bcrypto package and updated package-lock.json

@bizmindx
Copy link
Author

bizmindx commented Mar 4, 2021

@pinheadmz you mean the loady and bufio dependencies?

@pinheadmz
Copy link
Member

No, I mean: dont just update bcrypto in package.json. Do that, then npm install and then commit, it should actaully include the bcrypto module in its entirety. See #871 for an example.

@Shrikee
Copy link

Shrikee commented May 12, 2021

Bump. Have issues with macOS on m1 w/o this mr

@pinheadmz
Copy link
Member

Thanks Joseph, closing this in favor of #1020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants